Experienced Devs

4032 readers

6 users here now

A community for discussion amongst professional software developers.

Posts should be relevant to those well into their careers.

For those looking to break into the industry, are hustling for their first job, or have just started their career and are looking for advice, check out:

Logo base by Delapouite under CC BY 3.0 with modifications to add a gradient

founded 2 years ago

MODERATORS

snowe@programming.dev

jmk1ng@programming.dev

drewsiferr@programming.dev

While reviewing a PR, you find some piece of code that seems to work perfectly well, but some functions are written in a style that you don't particularly favor. What do you do? (cupid.careers)

submitted 2 days ago by rglullis to c/experienced_devs@programming.dev

15 comments fedilink hide all child comments

you are viewing a single comment's thread
view the rest of the comments

[–] Kissaki@programming.dev 4 points 2 days ago

I am interpreting "don't particularly favor" as not particularly significant nor important for me personally nor in general.

Add a comment
- explaining, in subjective wording, why I prefer it differently
- adding a change suggestion that may or may not be applied to demonstrate it
- a personal conclusion and assessment, how important or significant it is to me, and what's fine by me even if not my preference; e.g. "pick what you prefer or want" or "consider change effort"/"fine for now" or whatever

I feel like "sending back to the owner" sounds too strong; although it practically is that, it is not about sending it back; I share my opinion and view, and let the owner decide at their discretion

Whether I suggest a guideline depends on what it is; whether consistency and conformance would be useful in such a case, not for personal, subjective preference, but for code consistency or because they end up preferring my suggestion too.