Experienced Devs

4032 readers

6 users here now

A community for discussion amongst professional software developers.

Posts should be relevant to those well into their careers.

For those looking to break into the industry, are hustling for their first job, or have just started their career and are looking for advice, check out:

Logo base by Delapouite under CC BY 3.0 with modifications to add a gradient

founded 2 years ago

MODERATORS

snowe@programming.dev

jmk1ng@programming.dev

drewsiferr@programming.dev

While reviewing a PR, you find some piece of code that seems to work perfectly well, but some functions are written in a style that you don't particularly favor. What do you do? (cupid.careers)

submitted 2 days ago by rglullis to c/experienced_devs@programming.dev

15 comments fedilink hide all child comments

you are viewing a single comment's thread
view the rest of the comments

[–] rglullis 1 points 1 day ago

I work with Python. Usage of formatting tools (black, ruff) are widely adopted. Part of its Zen is "there should be one way to do it", most of its idioms are widely adopted and if you ask anyone about an example of a PEP, they will respond with "8".

That is to say, "how python code should look" is somewhat of a solved problem. Any occasional differences that might show up in a codebase are likely to be minor that are simply not worth arguing for.

I think that the interviewer was mostly looking for an answer where I could talk about how I deal with conflict. But to be honest if that was the case I would be either more straightforward about the question, or I would try a different scenario with something that might happen more frequently.