			{
				emit differentFiles (ckFile.absoluteFilePath(),
					otherFile.absoluteFilePath(),
					FileCompareWorker::FileComparisonParams{FileComparisonParams::FileNameMatch,
						(ckFile.size() > otherFile.size()) ? FileComparisonParams::File1IsLarger
							: FileComparisonParams::File2IsLarger});
			}

After Alignment

			{
				emit differentFiles (ckFile.absoluteFilePath(),
					otherFile.absoluteFilePath(),
					FileCompareWorker::FileComparisonParams{FileComparisonParams::FileNameMatch,
						(ckFile.size() > otherFile.size()) ? FileComparisonParams::File1IsLarger
														   : FileComparisonParams::File2IsLarger});
			}

you are viewing a single comment's thread
view the rest of the comments

[–] bleistift2@sopuli.xyz 16 points 17 hours ago (1 children)

I find both horrifying.

This is how I’d want to read it:

			{
				emit differentFiles(
					ckFile.absoluteFilePath(),
					otherFile.absoluteFilePath(),
					FileCompareWorker::FileComparisonParams{
						FileComparisonParams::FileNameMatch,
						(ckFile.size() > otherFile.size())
							? FileComparisonParams::File1IsLarger
							: FileComparisonParams::File2IsLarger
					}
				);
			}

[–] ulterno@programming.dev 1 points 4 hours ago* (last edited 4 hours ago)

That looks nice and easy to understand.
I would go one step further and according to my preferences:
(starting from line5)

FileCompareWorker::FileComparisonParams
{
	FileComparisonParams::FileNameMatch,
	(ckFile.size() > otherFile.size())
		? FileComparisonParams::File1IsLarger
		: FileComparisonParams::File2IsLarger
}

Break before the curly as I do for most.