Don't worry half of those will be useless code comments
Programmer Humor
Welcome to Programmer Humor!
This is a place where you can post jokes, memes, humor, etc. related to programming!
For sharing awful code theres also Programming Horror.
Rules
- Keep content in english
- No advertisements
- Posts must be related to programming or programmer topics
- If the mod doesn't find it funny, you're banned. Ha-ha!... For real: do not use the community for "statements". There are other places for such content. Keep it chill and funny.
// Here I'm not using that other thing that is now completely irrelevant, but I'll leave a comment to the non-existing thing anyway because I'm avoiding it.
REEEEEEEEEEEEEEEEEEEEEEEEEEEEEEE
The comment:
# This code does exactly what you asked: Never change state, only fetch the state and return the difference
the code: hallucinated database table drops
Repeat after me: "Rejected. Reason: too large of a change for one PR."
I struggle to review a 1k line change. When people give me such big changes I normally don't believe they've reviewed them either.
That's because they haven't.
Mystery solved!
Try working on a codebase that's all event-driven hexagonal CQRS with hand-crafted SQL for persistence. Add additional buzzwordy methodologies to taste.
Adding a single property to your product means you now have to update an aggregate class, several DTOs, and several event classes and handlers before you can even think about touching the UI.
And that's in your main solution. There's also at least one facade service you'll need to make compatible and you also need to update the event simulator used for testing. The latter night involve having to touch every single line in a 2000 lines long SQL script.
Having to go though three separate 600-2000 LOC PRs for one PBI isn't that exotic.
The problem with Claude is that it doesn't write code to be modular & reusable. Every tiny change requires a complete rewrite.
I've completely banned any code that can't be explained. I've had my CTO send me code at 3 AM to implement and when I ask him what I'm looking at he just says it doesn't need review, just push it.
Uhh, no sir, I'm not doing shit because you've handed me GCC and we're MSVC.
After I bitched endlessly to the CEO about that he said I have final say on what goes into the project.
I've had my CTO send me code at 3 AM
I hope you don't even respond until your next normal working hours!
I love my job, even when I have to deal with nonsense like that and I'm compensated very well to be on call 24/7.
No amount of money would make me put my health at risk like that. Been there at a job before where I was always working. No thanks.
we're msvc
Then switch to a real compiler on a real operating system, duh
No
You ask your LLM of choice to look it over, completing the shit-cycle
I fully expect this to become the new normal being pushed by management.
"We identified PR reviews to be blocking our newfound AI-powered efficiency, so we are now mandating all the reviews to done by AI. Also we figured all the developers are now useless since all you do is ask Claude to solve tickets, so you are all fired"
I wonder how long it takes for the first high profile disaster happening because of a policy like that.
We've had a very recent uptick in engineers submitting PRs of hundreds of lines across multiple files, for Jira tickets that only asked for a one-line change. The engineers involved have been using AI assistants for nearly two years now, but there seems to have been a change in the last month or so in how aggressive the new models are at changing code.
LGTM
Let's Go Topple the Monarchy!
That's an automatic reject from me, that's not a patch, it's an overhaul
🛑 Changes requested
Too big. Break into smaller individual PRs.
Merge that shit, watch it all collapse, enjoy your forever holiday
"So, Daywim. Why did you let this obviously aweful PR pass your desk causing so much trouble for our company? I'm afraid we have to let you go because of this questionable performance." - Corporate
What part of forever holiday did you miss?
I interpreted it as "Holiday that lasts forever because the company can't work anymore" but I guess it is meant to mean "Holiday that lasts forever cause you got fired"?
"Looks like I overlooked something in this 6k PR full of im meaningless dribble. Why don't you ask the person who comitted the code how he overlooked this bug. Its his respinsibility"
Just throw the the slop creator under the bus.
Throw them under the bus by rejecting their PR. Integrity is your responsibility, the gesture is theirs. They'll get shit for not getting their stuff done.
If you're the reviewer you share responsibility if there's an issue with the PR. Hopefully your teams culture is such that issues like that are treated as a learning experience, rather than a reason to pile on the individuals involved.
If you can't be bothered to write your own code, I can't be bothered to review
It is not even peer review anymore, unless we are pretending that claude is our peer.
Our PR checks auto reject the PR if it has 1k changes
is it auto reject, or just doesn't auto approve and leaves it open for manual review
It seems weird that you can't do a pr at all with 1000 line changes, any moderate size feature addition could hit that mark
Yep.
We have one PR still blocked. Last change is a simple comment from me “Why ?”
The most important question that every change must answer.
No Mr Bond, i expect you to approve
If LLM can make big PR, LLM can split PRs
The goal of AI providers is to make humans unable to maintain code, so you have to rely on their expensive subscriptions and tokens.
And people were already annoyed when I had ~90 changes due to refactoring and fixing imports ...
This is a joke I'm not college educated enough to understand.
It's basically saying "insert one ass loads of code in one go, all written by AI".